[wip] feat(observability/metrics): add Emitter, options, buckets, and shared utils#157
Draft
xytan0056 wants to merge 1 commit into
Draft
[wip] feat(observability/metrics): add Emitter, options, buckets, and shared utils#157xytan0056 wants to merge 1 commit into
xytan0056 wants to merge 1 commit into
Conversation
xytan0056
force-pushed
the
pr1-emitter-core
branch
from
5a5d063 to
c1f00c2
Compare
xytan0056
changed the title
xytan0056
force-pushed
the
pr1-emitter-core
branch
7 times, most recently
from
def6e80 to
5179b24
Compare
xytan0056
changed the title
xytan0056
force-pushed
the
pr1-emitter-core
branch
4 times, most recently
from
0dacdc7 to
6c901b8
Compare
…d names Emitter is an interface; the default implementation wraps tally.Scope with op-as-subscope semantics, base tags via Tagged, default histogram buckets, and TrackInFlight. New(nil) is safe (NoopScope).
xytan0056
force-pushed
the
pr1-emitter-core
branch
from
6c901b8 to
d63fdd9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces the
observability/metricspackage skeleton — a thin flavoured wrapper over tally.Scope with op-as-subscope semantics, per-emitter base tags via Tagged, and default histogram buckets.nil-scope is safe.No consumers migrate in this PR; adoption comes later.
Why?
What?
Test Plan
Issue